[webkit-reviews] review denied: [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing : [Attachment 141425] proposed fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Balazs Ankes <bank at inf.u-szeged.hu>'s
request for review:
Bug 67935: webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is
missing
https://bugs.webkit.org/show_bug.cgi?id=67935

Attachment 141425: proposed fix
https://bugs.webkit.org/attachment.cgi?id=141425&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141425&action=review


Changes to webkitpy require unit tests.  Both changelog.py and
updatechangelogswithreviewer.py have unit tests that should be easy to extend
to test this change.

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:75
> +		   if not self._tool.user.confirm("Do you want to continue?",
default="n"):

Do we need to check the --non-interactive option before prompting the user?

> Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:76
> +			   self._exit(1)

Is this the proper way to exist, or should we call error() ?