[webkit-reviews] review granted: [Bug 86211] Web Inspector: add Profiler.getHeapObjectId command : [Attachment 141405] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 86211: Web Inspector: add Profiler.getHeapObjectId command
https://bugs.webkit.org/show_bug.cgi?id=86211

Attachment 141405: Patch
https://bugs.webkit.org/attachment.cgi?id=141405&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141405&action=review


> Source/WebCore/inspector/Inspector.json:2680
> +		       { "name": "heapSnapshotObjectId", "type": "string",
"description": "Heap snapshot object id." }

Please introduce type for the id.

> Source/WebCore/inspector/InspectorProfilerAgent.cpp:455
> +    ScriptValue jsValue = injectedScript.findObjectById(objectId);

jsValue -> value.