[webkit-reviews] review denied: [Bug 86202] Web Inspector: Can't type spaces in "Override User Agent" field : [Attachment 141394] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 86202: Web Inspector: Can't type spaces in "Override User Agent" field
https://bugs.webkit.org/show_bug.cgi?id=86202

Attachment 141394: Patch
https://bugs.webkit.org/attachment.cgi?id=141394&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141394&action=review


> Source/WebCore/inspector/front-end/HelpScreen.js:50
> +    this.closeKeys = [

Can we have a virtual method instead and override it in SettingsScreen or pass
the key set as a parameter to the constructor? We don't override fields in the
front-end code.