[webkit-reviews] review granted: [Bug 86055] [BlackBerry] [DRT] Ref-tests were not run by torch-launcher : [Attachment 141333] Git patch updated for comments from Bob and Ming

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 86055: [BlackBerry] [DRT] Ref-tests were not run by torch-launcher
https://bugs.webkit.org/show_bug.cgi?id=86055

Attachment 141333: Git patch updated for comments from Bob and Ming
https://bugs.webkit.org/attachment.cgi?id=141333&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141333&action=review


Looks much better! Please fix remaining issues before landing.

> ChangeLog:8
> +	   Ref-tests are tests with surfix "-expected", "-expected-mismatch"
and a valid

surfix!

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:209
> +    const char* extensions[] = {".html"};

We may want to add .svg as possible ref-test extension later.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:222
> +

Remove empty line.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:401
> +    // and multiple mismatch ref-tests

Lacks a period at the end.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:403
> +	   getRefTests(*iter);

I think it should be getRefTest, not getRefTests.