[webkit-reviews] review requested: [Bug 86194] [EFL] Rounding errors on 32-bit machines causes tests to fail : [Attachment 141376] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 04:03:36 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 86194: [EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194

Attachment 141376: Patch
https://bugs.webkit.org/attachment.cgi?id=141376&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Use scalar floating-point instructions present in the SSE instruction set on
32-bit. This is the default choice for the x86-64 compiler but not for 32-bit.
Without enabling this, we get a lot of rounding errors on 32-bit machines
causing a lot of tests to fail (off by 1 pixel).

The same issue was reported on GTK port and solved in the same way:
Bug 72254


More information about the webkit-reviews mailing list