[webkit-reviews] review denied: [Bug 86058] [Forms] Move ValidityState methods implementation to another place : [Attachment 141343] Patch 10

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 86058: [Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058

Attachment 141343: Patch 10
https://bugs.webkit.org/attachment.cgi?id=141343&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141343&action=review


> Source/WebCore/html/FormAssociatedElement.h:64
> +    virtual bool customError() const;

We don't need to make this virtual.

> Source/WebCore/html/FormAssociatedElement.h:70
> +    virtual bool patternMismatch() const;
> +    virtual bool rangeOverflow() const;
> +    virtual bool rangeUnderflow() const;
> +    virtual bool stepMismatch() const;
> +    virtual bool tooLong() const;
> +    virtual bool typeMismatch() const;

We should add a comment that an override function must call willValidate().

> Source/WebCore/html/FormAssociatedElement.h:71
> +    virtual bool valid() const;

We don't need to make this virtual.

> Source/WebCore/html/FormAssociatedElement.h:72
> +    virtual bool valueMissing() const;

We should add a comment that an override function must call willValidate().