[webkit-reviews] review requested: [Bug 86058] [Forms] Move ValidityState methods implementation to another place : [Attachment 141343] Patch 10
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 11 01:32:32 PDT 2012
yosin at chromium.org has asked for review:
Bug 86058: [Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058
Attachment 141343: Patch 10
https://bugs.webkit.org/attachment.cgi?id=141343&action=review
------- Additional Comments from yosin at chromium.org
Thanks for review. I updated this patch as you suggested.
Failure of EWS-WIN doesn't relate to my patch, I copy/paste error message at
botton.
Thanks in advance.
..\WebProcess\WebCoreSupport\win\WebPopupMenuWin.cpp(122) : error C2664:
'WebCore::TextRun::TextRun(const UChar
*,int,float,float,WebCore::TextRun::ExpansionBehavior,WebCore::TextDirection,bo
ol,bool,WebCore::TextRun::RoundingHacks)' : cannot convert parameter 6 from
'WebCore::TextRun::ExpansionBehaviorFlags' to 'WebCore::TextDirection'
7> Conversion to enumeration type requires an explicit cast
(static_cast, C-style cast or function-style cast)
More information about the webkit-reviews
mailing list