[webkit-reviews] review granted: [Bug 86108] Web Inspector: [Extensions API] add audit formatters for remote objects and DOM elements : [Attachment 141334] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 86108: Web Inspector: [Extensions API] add audit formatters for remote
objects and DOM elements
https://bugs.webkit.org/show_bug.cgi?id=86108

Attachment 141334: Patch
https://bugs.webkit.org/attachment.cgi?id=141334&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141334&action=review


> Source/WebCore/inspector/front-end/AuditFormatters.js:101
> +    object: function(expression, title)

You should start annotating your code.

> Source/WebCore/inspector/front-end/AuditFormatters.js:115
> +    node: function(expression)

ditto

> Source/WebCore/inspector/front-end/AuditFormatters.js:118
> +	   function onNodeAvailable(nodeId)

Annotate please

> Source/WebCore/inspector/front-end/AuditFormatters.js:122
> +	       if (!treeOutline.children[0].hasChildren)

I don't think we need it, if we do, this code should be in the elements tree
outline.

> Source/WebCore/inspector/front-end/AuditFormatters.js:126
> +	   function onEvaluate(remoteObject)

Annotate please

> Source/WebCore/inspector/front-end/AuditFormatters.js:136
> +    evaluate: function(expression, callback)

Annotate please

> Source/WebCore/inspector/front-end/AuditFormatters.js:138
> +	   function onEvaluate(error, result, wasThrown)

Annotate please

> LayoutTests/inspector/extensions/extensions-audits-expected.txt:36
> +		=​"

Consider filtering out zero-with whitespaces from the output.

> LayoutTests/inspector/extensions/extensions-audits-tests.js:23
> +	       InspectorTest.runAfterPendingDispatches(function() {

See the way it is implemented in elements-tests.js