[webkit-reviews] review requested: [Bug 23750] Cannot resize frames because frameborder=0 : [Attachment 141332] Patch to allow resize of frames even in case of frameborder=0. - IV

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 23:23:16 PDT 2012


Swapna <spottabathini at innominds.com> has asked	for review:
Bug 23750: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750

Attachment 141332: Patch to allow resize of frames even in case of
frameborder=0. - IV
https://bugs.webkit.org/attachment.cgi?id=141332&action=review

------- Additional Comments from Swapna <spottabathini at innominds.com>
> This seems reasonable to me.	I wouldn't have used alerts for logging as they
make the test painful to use manually. 
Removed usage of alerts for logging.

> You also seem to have a bunch of code in your test case which is not
executed.
 In the test case the code mentioned under if(window.layoutTestController) is
to be executed in layout test tool. And the rest code is to execute in browser.
By this code, while we run the test case in browser it will give look and feel
of resize of frames.


More information about the webkit-reviews mailing list