[webkit-reviews] review requested: [Bug 83283] [chromium] Ensure that animations continue to run when transform-style is changed : [Attachment 141331] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 22:57:21 PDT 2012


vollick at chromium.org has asked	for review:
Bug 83283: [chromium] Ensure that animations continue to run when
transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283

Attachment 141331: Patch
https://bugs.webkit.org/attachment.cgi?id=141331&action=review

------- Additional Comments from vollick at chromium.org
There was some logic added to CCLayerAnimationController to handle the case
where we've dropped the impl tree. Since this is no longer done, I've removed
this code.

(In reply to comment #15)
> (From update of attachment 141210 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=141210&action=review
>
> >
LayoutTests/animations/change-transform-style-during-animation-expected.txt:1
> > +layer at (0,0) size 800x600
>
> we shouldn't have a render tree dump on this - use
layoutTestController.dumpAsText(true) to suppress this output and have the
output just be the textContent of the document (i.e. the string "PASS - ..."
Done.
>
> > LayoutTests/platform/chromium/test_expectations.txt:3886
> > +// Will need to rebaseline once results are generated for these platforms
>
> if you fix the test to output only text+pixels instead of a render tree you
won't need this
Removed.


More information about the webkit-reviews mailing list