[webkit-reviews] review requested: [Bug 86156] Chromium Valgrind layout tests missing environment variables : [Attachment 141292] Patch to let the Chromium test scripts add the missing envvars.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 16:38:03 PDT 2012


Lei Zhang <thestig at chromium.org> has asked  for review:
Bug 86156: Chromium Valgrind layout tests missing environment variables
https://bugs.webkit.org/show_bug.cgi?id=86156

Attachment 141292: Patch to let the Chromium test scripts add the missing
envvars.
https://bugs.webkit.org/attachment.cgi?id=141292&action=review

------- Additional Comments from Lei Zhang <thestig at chromium.org>
I think recent changes made DumpRenderTree and ImageDiff run inside
environments created by port.setup_environment_for_server(). As a result of
these changes, the VALGRIND_LIB and VALGRIND_LIB_INNER envvars that the
Chromium Valgrind script set got lost. We should put them back.


More information about the webkit-reviews mailing list