[webkit-reviews] review denied: [Bug 86055] [BlackBerry] [DRT] Ref-tests were not run by torch-launcher : [Attachment 141094] Git patch updated for code style

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 86055: [BlackBerry] [DRT] Ref-tests were not run by torch-launcher
https://bugs.webkit.org/show_bug.cgi?id=86055

Attachment 141094: Git patch updated for code style
https://bugs.webkit.org/attachment.cgi?id=141094&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141094&action=review


Looks good, can be cleaned up some more.

> ChangeLog:1
> +2012-05-09  Xiaobo Wang  <xbwang at torchmobile.com.cn>

You need an empty line here.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:206
> +    const char* surfixes[] = {"-expected", "-expected-mismatch"};

Typo, suffix.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:207
> +    const int countofSurfixes = sizeof(surfixes) / sizeof(const char*);

Ditto.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:406
> +    for (Vector<WTF::String>::iterator iter = files.begin(); files.end() !=
iter; ++iter)

Can you try if it works if you do not add WTF:: in this cpp file?