[webkit-reviews] review granted: [Bug 80170] Contents of noscript elements turned into strings in WebArchives : [Attachment 141229] Patch v1

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 80170: Contents of noscript elements turned into strings in WebArchives
https://bugs.webkit.org/show_bug.cgi?id=80170

Attachment 141229: Patch v1
https://bugs.webkit.org/attachment.cgi?id=141229&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141229&action=review


> Source/WebCore/editing/MarkupAccumulator.h:73
> +    String serializeNodes(Node* targetNode, Node* nodeToSkip, EChildrenOnly,
Vector<QualifiedName>* tagNamesToSkip);

You should make this new argument optional.

> Source/WebCore/page/PageSerializer.cpp:217
> +    String text = accumulator.serializeNodes(document->documentElement(), 0,
IncludeNode, 0);

You wouldn't have to change this line if the new argument to serializeNodes()
were optional.