[webkit-reviews] review granted: [Bug 85399] [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly : [Attachment 141227] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85399: [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag
directly
https://bugs.webkit.org/show_bug.cgi?id=85399

Attachment 141227: Patch
https://bugs.webkit.org/attachment.cgi?id=141227&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141227&action=review


> Source/WebCore/platform/EventTracer.cpp:51
> +int EventTracer::addTraceEvent(char,
> +					const unsigned char*,
> +					const char*,
> +					unsigned long long,
> +					int,
> +					const char**,
> +					const unsigned char*,
> +					const unsigned long long*,
> +					int,
> +					long long,
> +					unsigned char)

This argument list looks a bit silly, but I'm not sure it matters too much.  I
might have combined these all into one line.  (Not worth uploading the patch
again.)

> Source/WebCore/platform/chromium/EventTracerChromium.cpp:44
> +int EventTracer::addTraceEvent(char phase,
> +					const unsigned char*
categoryEnabledFlag,

The indents should probably line up.