[webkit-reviews] review granted: [Bug 85940] Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element : [Attachment 141220] Updated as discussed

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 85940: Make IFRAME_SEAMLESS child documents inherit styles from their
parent iframe element
https://bugs.webkit.org/show_bug.cgi?id=85940

Attachment 141220: Updated as discussed
https://bugs.webkit.org/attachment.cgi?id=141220&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141220&action=review


> Source/WebCore/css/StyleResolver.cpp:1540
> +	       // Early-return to avoid overriding inheritted styles.
> +	       return documentStyle.release();

This still needs a FIXME. I had said I was OK with the previous patch + FIXME
mainly because early returning is also not fully correct. If you set designMode
on the iframe's document or writing mode on the documentElement, then we do the
wrong thing now.

Making this code do the right thing isn't actually hard. It just requires
carefully looking at the code below and applying the right bits. 

I'm fine with the code either way for now as long as there is a clear FIXME.