[webkit-reviews] review granted: [Bug 86063] Move resumeAnimations to use Internals interface : [Attachment 141128] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 11:51:49 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 86063: Move resumeAnimations to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=86063

Attachment 141128: Patch
https://bugs.webkit.org/attachment.cgi?id=141128&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141128&action=review


> Source/WebKit/mac/WebKit.order:-1224
> --[WebFrame(WebPrivate) _resumeAnimations]

There is no need to update these order files. No harm either.

> Source/WebKit/mac/WebView/WebFramePrivate.h:-111
> -// Suspend and resume animations (includes both CSS transitions and CSS
animations).
> -- (void)_resumeAnimations;

It's always scary to remove anything from *Private.h files - functions in these
can be used by Apple software. I verified that this change is OK to the extent
possible.


More information about the webkit-reviews mailing list