[webkit-reviews] review denied: [Bug 85642] keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux : [Attachment 140307] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied wez at chromium.org's request for
review:
Bug 85642: keydown and keyup events have zero keycode for some numeric pad keys
under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642

Attachment 140307: Patch
https://bugs.webkit.org/attachment.cgi?id=140307&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140307&action=review


> Source/WebCore/ChangeLog:8
> +	   This patch adds mappings for GDK_KP_Begin, GDK_KP_Insert and
GDK_KP_Delete.	There are no keycode conversion routine tests, so no tests are
updated.

You should be able to add a gtest to webkit_unit_tests for this. 
windowsKeyCodeForKeyEvent is just a function that you can call directly.