[webkit-reviews] review denied: [Bug 85954] Web Intents code only supports V8 : [Attachment 141156] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 85954: Web Intents code only supports V8
https://bugs.webkit.org/show_bug.cgi?id=85954

Attachment 141156: Patch
https://bugs.webkit.org/attachment.cgi?id=141156&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141156&action=review


This patch is much better!  There are just a couple minor things below.

> Source/WebCore/bindings/js/Dictionary.cpp:70
> +	       JSValue value = object->get(exec, *it);

What if this throws an exception?  It's possible that we want to ignore
exceptions.  What does JSDictionary do with exceptions like these?

> Source/WebCore/bindings/js/Dictionary.cpp:72
> +		   map.set(stringKey, String(value.toUString(exec).impl()));

What if this throws an exception?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2839
> +sub GetNativeTypeForCallbacks

Can you run run-bindings-tests --reset-results to update the references files
we have checked in?  That will help us understand the effects of changing this
file.