[webkit-reviews] review granted: [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand : [Attachment 140821] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis.menard at openbossa.org> has granted Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 27577: [CSS3 Backgrounds and Borders] Add background-size to the background
shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577

Attachment 140821: Patch
https://bugs.webkit.org/attachment.cgi?id=140821&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
r=me. It is very unlikely that code would rely on the internal representation
of the shorthand. In addition, the support of the shorthand property in
getComputedStyle was added by myself 3-4 months ago (before NULL was returned)
so the behavior change happening in this patch would mean that the breakage
would be for people relying on this internal representation (which is not
recommended by the spec) in the last 3-4 months. Only the last version of
Chrome (18) ships the support of the background shorthand in general so it is
fine. I agree with kling that the internal representation is a bit cumbersome,
and it could be fixed in another patch by supporting creating CSSValueList with
mixed separators (without increasing the number of items of the list) which is
probably possible today. But what this patch fix and is very welcome is the
support of the background-size in the shorthand which is a long standing bug
(Opera and FF are supporting this feature).