[webkit-reviews] review denied: [Bug 85711] Web Inspector: Turn HelpScreen to be View. : [Attachment 141151] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 85711: Web Inspector: Turn HelpScreen to be View.
https://bugs.webkit.org/show_bug.cgi?id=85711

Attachment 141151: Patch
https://bugs.webkit.org/attachment.cgi?id=141151&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141151&action=review


> Source/WebCore/inspector/front-end/HelpScreen.js:39
> +    this.markAsRoot();

You are showing it as a child of inspector view, no need to mark as root.

> Source/WebCore/inspector/front-end/HelpScreen.js:70
> +    present: function(onHide)

Naming of the function is not clear.