[webkit-reviews] review denied: [Bug 85058] [EFL][DRT] ewk_view_paint_contents may trigger assertion failure : [Attachment 141154] Updated, rebased patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 10 05:53:18 PDT 2012
Gustavo Noronha (kov) <gns at gnome.org> has denied Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 85058: [EFL][DRT] ewk_view_paint_contents may trigger assertion failure
https://bugs.webkit.org/show_bug.cgi?id=85058
Attachment 141154: Updated, rebased patch.
https://bugs.webkit.org/attachment.cgi?id=141154&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141154&action=review
> Source/WebKit/efl/ewk/ewk_view.cpp:2810
> + if (view->needsLayout())
> + view->forceLayout();
To me this looks like using too strong a force. Why don't you call
view->updateLayoutAndStyleIfNeededRecursive() unconditionally instead?
More information about the webkit-reviews
mailing list