[webkit-reviews] review granted: [Bug 86027] Crash in 3rd party WebKit apps that disable cache at a wrong time : [Attachment 141040] proposed fix

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 86027: Crash in 3rd party WebKit apps that disable cache at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=86027

Attachment 141040: proposed fix
https://bugs.webkit.org/attachment.cgi?id=141040&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=141040&action=review


r=me

> Source/WebCore/ChangeLog:12
> +	   The fix is to use CacheResourceHandle throughout MemoryCache, which
will certainly
> +	   keep the resource alive. Also removed earlier fixes.

Seems like a good idea. The only worry is that using CachedResourceHandles as
stack objects will create some HashMap churn in
CachedResource::registerHandle/unregisterHandle for the revalidation case. I
think that should be ok in practice though.

Typo CacheResourceHandle ->CachedResourceHandle