[webkit-reviews] review denied: [Bug 86022] Refactor layer-related logic out of RenderBoxModelObject : [Attachment 141038] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 9 16:42:21 PDT 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 86022: Refactor layer-related logic out of RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=86022
Attachment 141038: Patch
https://bugs.webkit.org/attachment.cgi?id=141038&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I don't think RenderLayerBase is a good name for something that
RenderBoxModelObject inherits from; that name implies that it's a base class of
RenderLayer.
The name should be RenderSomethingBox or RenderBoxSomething.
RenderBoxModelObject was actually created for this very purpose a while back,
so perhaps you should investigate why RenderSVGModelObject can't inherit from
RenderBoxModelObject.
More information about the webkit-reviews
mailing list