[webkit-reviews] review granted: [Bug 86011] CopiedSpace does not add pinned blocks back to the to-space filter : [Attachment 141007] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 15:19:04 PDT 2012


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 86011: CopiedSpace does not add pinned blocks back to the to-space filter
https://bugs.webkit.org/show_bug.cgi?id=86011

Attachment 141007: Patch
https://bugs.webkit.org/attachment.cgi?id=141007&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141007&action=review


r=me

Please add Radar link

> Source/JavaScriptCore/heap/CopiedSpace.cpp:186
> +	       // We don't add the block to the toSpaceSet because it was never
removed.

You should ASSERT this condition.


More information about the webkit-reviews mailing list