[webkit-reviews] review granted: [Bug 85758] [Chromium] Move clipboard to Platform.h : [Attachment 141016] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85758: [Chromium] Move clipboard to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85758

Attachment 141016: Patch
https://bugs.webkit.org/attachment.cgi?id=141016&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141016&action=review


> Source/Platform/chromium/public/Platform.h:67
>      // Must return non-null.
> +    virtual WebClipboard* clipboard() { return 0; }
> +
> +    // Must return non-null.
>      virtual WebMimeRegistry* mimeRegistry() { return 0; }

These comments do seem odd next to these default implementations, but I think
its ok.  Can we use ASSERT_NOT_REACHED() in API headers?  I suspect we're not
able to.

> Source/WebKit/chromium/src/DragClientImpl.cpp:43
>  
> +#include <public/WebDragData.h>

There's no need for this blank line.

> Source/WebKit/chromium/src/WebDragData.cpp:42
> +#include <public/WebDragData.h>

This header should have been left just after config.  You probably got a style
warning, but that's a bug in the style checker.