[webkit-reviews] review granted: [Bug 86017] add some basic perf-o-matic tests for flexbox : [Attachment 141012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 14:38:41 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 86017: add some basic perf-o-matic tests for flexbox
https://bugs.webkit.org/show_bug.cgi?id=86017

Attachment 141012: Patch
https://bugs.webkit.org/attachment.cgi?id=141012&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141012&action=review


> PerformanceTests/Layout/flexbox-column-nowrap.html:31
> +PerfTestRunner.run(runTest, 180, 20, function() {

It's fragile to rely on hard-coded values like this.

>> PerformanceTests/Layout/flexbox-column-nowrap.html:33
>> +});
> 
> Do I need the done function?	Without it, the column tests failed, but the
row tests passed.

done is called after all tests have ran.


More information about the webkit-reviews mailing list