[webkit-reviews] review granted: [Bug 85916] [Chromium] Expose WebPluginContainer of WebPlugin to embedder : [Attachment 141011] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 85916: [Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Attachment 141011: Patch
https://bugs.webkit.org/attachment.cgi?id=141011&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141011&action=review


> Source/WebKit/chromium/public/WebPlugin.h:58
> +    // FIXME: Make this pure virtual once all derived classes implement
this.

nit: add a new line here

nit: we actually have a policy that embedder implemented interfaces do not need

to have pure virtual methods.  that way it is easier to make API changes, so
you can just drop this comment.