[webkit-reviews] review granted: [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files : [Attachment 140967] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Balazs Ankes
<bank at inf.u-szeged.hu>'s request for review:
Bug 75825: webkit-patch land should automatically add svn:mime-type for .png
files
https://bugs.webkit.org/show_bug.cgi?id=75825

Attachment 140967: proposed fix
https://bugs.webkit.org/attachment.cgi?id=140967&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140967&action=review


marking cq- just so you can take a look at my suggestion and see if it works.
looks good otherwise.

> Tools/Scripts/webkitpy/common/checksvnconfigfile.py:51
> +    for line in config_file.split('\n'):

I wonder if this would be easier and clearer if you didn't split the file and
just did two re.search()'s against the whole string, i.e.

errorcode_autoprops = not re.search("\s*enable-auto-props\s*=\s*yes",
config_file)
errorcode_png = not re.search("\s*\*\.png\s*=\s*svn:mime-type=image/png",
config_file)

or something like that (I'm not sure how you'd handle commented out lines, so
you might have to experiment a bit)?