[webkit-reviews] review granted: [Bug 85425] Use suitable viewport values when a Mobile DTD is used. : [Attachment 140991] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 85425: Use suitable viewport values when a Mobile DTD is used.
https://bugs.webkit.org/show_bug.cgi?id=85425

Attachment 140991: Patch
https://bugs.webkit.org/attachment.cgi?id=140991&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140991&action=review


This looks good to me and should be OK to land given it is kept behind a
feature flag and it already specified (though indirectly) in the spec. Please
also fix the wording before landing.

> LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-misplaced.html:14
> +    However XHTML-MP is a legacy way of setting the viewport, so the
viewport
> +    metatag takes precedence.

so any viewport related meta tag takes precedence.

> LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-misplaced.html:16
> +    This test if a missplaced XHTML-MP doctype entry doesn't change the
already

This test checks that ... does not viewport.