[webkit-reviews] review granted: [Bug 85938] [BlackBerry] Refactor data scheme support : [Attachment 140914] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 10:57:58 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 85938: [BlackBerry]  Refactor data scheme support
https://bugs.webkit.org/show_bug.cgi?id=85938

Attachment 140914: Patch
https://bugs.webkit.org/attachment.cgi?id=140914&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140914&action=review


LGTM.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-90
> -    out.resize(dst - out.data());

Is there anything more you can remove because this gets removed? Maybe #include
<wtf/ASCIICType.h> ?


More information about the webkit-reviews mailing list