[webkit-reviews] review granted: [Bug 85976] [chromium] Exposes OrientationChangeEvent. : [Attachment 140906] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 85976: [chromium] Exposes OrientationChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=85976

Attachment 140906: Patch
https://bugs.webkit.org/attachment.cgi?id=140906&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140906&action=review


> Source/WebKit/chromium/public/WebFrame.h:570
> +    virtual void sendOrientationChangeEvent(int orientation) = 0;

This comment from Frame.h was helpful to me.  I wonder if we should include it
here too:

	// Orientation is the interface orientation in degrees. Some examples
are:
	//  0 is straight up; -90 is when the device is rotated 90 clockwise;
	//  90 is when rotated counter clockwise.