[webkit-reviews] review requested: [Bug 77662] [chromium] Add impl-thread support for fill-mode and direction css animation properties : [Attachment 140950] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 77662: [chromium] Add impl-thread support for fill-mode and direction css
animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662

Attachment 140950: Patch
https://bugs.webkit.org/attachment.cgi?id=140950&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #3)
> (From update of attachment 135354 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=135354&action=review
>
> > Source/WebCore/ChangeLog:3
> > +	     [chromium] Add impl-thread support for all css animation
properties.
>
> I think "all" is a bit ambitious. Can you say specifically what this patch is
adding support for?
Done.
>
> > Source/WebKit/chromium/src/TextFieldDecoratorImpl.cpp:36
> > +#include "Image.h"
>
> this looks unrelated
Removed.
>
> > Source/WebKit/chromium/tests/CCActiveAnimationTest.cpp:72
> > +TEST(CCActiveAnimationTest, TrimTimeAlternating)
>
> is this sufficient test coverage?  should we have some tests for reverse as
well?
It isn't. Added tests to cover reverse.