[webkit-reviews] review denied: [Bug 84048] ShadowRoot needs resetStyleInheritance : [Attachment 139609] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 04:54:26 PDT 2012


Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 84048: ShadowRoot needs resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=84048

Attachment 139609: Patch
https://bugs.webkit.org/attachment.cgi?id=139609&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139609&action=review


> Source/WebCore/css/StyleResolver.cpp:1604
> +    bool crossShadowBoundary = element && m_parentNode &&
element->treeScope() != m_parentNode->treeScope();

I noticed that we don't need to compare tree scopes to detect the boundary.
We compute m_parentNode using Node::parentNodeForRenderingAndStyle(), which is
implemented using NodeRenderingContext.
And NodeRenderingContext should know what we need to know.
I think we can use it directly instead of calling
parentNodeForRenderingAndStyle().
Or we can add an extra out-parameter to pass necessary information.
Then we don't need to re-query tree scope of each node.


More information about the webkit-reviews mailing list