[webkit-reviews] review denied: [Bug 85883] MediaStream API: Adding a test for constructed from JS MediaStreams : [Attachment 140714] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 85883: MediaStream API: Adding a test for constructed from JS MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=85883

Attachment 140714: Patch
https://bugs.webkit.org/attachment.cgi?id=140714&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review


> LayoutTests/fast/mediastream/MediaStreamConstructor.html:14
> +function shouldNotThrow(expression)
> +{

* This should be in js-test-pre.js.

* The position of { is inconsistent with other functions.

> LayoutTests/fast/mediastream/MediaStreamConstructor.html:21
> +  try {
> +    eval(expression);
> +    testPassed(expression + " did not throw exception.");
> +  } catch(e) {
> +    testFailed(expression + " should not throw exception. Threw exception "
+ e);
> +  }
> +}

We usually use four-space indentation in JavaScript code.
We usually put ' ' after 'catch'.