[webkit-reviews] review granted: [Bug 83634] IDL and implementation for Web Intents delivery : [Attachment 140744] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 83634: IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634

Attachment 140744: Patch
https://bugs.webkit.org/attachment.cgi?id=140744&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140744&action=review


> Source/WebKit/chromium/src/DeliveredIntentClientImpl.h:41
> +namespace WTF { template <typename T> class PassRefPtr; }
> +
> +namespace WebCore {
> +class SerializedScriptValue;
> +}

This isn't an API header.  You can just include the actual headers if you like.


> Source/WebKit/chromium/src/WebFrameImpl.cpp:1897
> +    HashMap<String, String> extras = webcoreIntent->extras();

You're creating an extra copy of the HashMap here.  If you just passed
webcoreIntent->extras() to DeliveredIntent::create directly, you could avoid
this copy.