[webkit-reviews] review granted: [Bug 83486] [EFL][DRT] EventSender needs implementation of leapForward function : [Attachment 140689] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Alexander Shalamov
<alexander.shalamov at gmail.com>'s request for review:
Bug 83486: [EFL][DRT] EventSender needs implementation of leapForward function
https://bugs.webkit.org/show_bug.cgi?id=83486

Attachment 140689: Patch
https://bugs.webkit.org/attachment.cgi?id=140689&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140689&action=review


Seems reasonable.  rs=me.

> Tools/DumpRenderTree/efl/EventSender.cpp:122
> +struct MouseEventInfo {

Structs tend to very quickly become classes. :)

> Tools/DumpRenderTree/efl/EventSender.cpp:302
> +    MouseEventInfo* eventInfo = new MouseEventInfo(EvasMouseEventMove);

OwnPtr?

> Tools/DumpRenderTree/efl/EventSender.cpp:700
> +    delete eventInfo;

:(  Manual memory management is sad times. :(

> Tools/DumpRenderTree/efl/EventSender.cpp:709
> +	       usleep(delayedEvent.delay * 1000);

This is sad.  That we need to artificially slow down the testing?