[webkit-reviews] review denied: [Bug 85633] [CSSRegions]Add region styling support for color property : [Attachment 140544] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 8 13:36:53 PDT 2012
Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 85633: [CSSRegions]Add region styling support for color property
https://bugs.webkit.org/show_bug.cgi?id=85633
Attachment 140544: Patch 2
https://bugs.webkit.org/attachment.cgi?id=140544&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140544&action=review
> Source/WebCore/rendering/RenderInline.cpp:216
> + || parentStyle->lineHeight() != style()->lineHeight()))
> + || inRenderFlowThread();
I would like to see more precision here. You really mean "I'm in a render flow
thread that has some custom styles." Let's not slow down the common case of no
custom styling (which is as much as a 5-10% performance hit).
More information about the webkit-reviews
mailing list