[webkit-reviews] review denied: [Bug 85670] [BlackBerry] Implement a popup client for HTML controls : [Attachment 140758] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 85670: [BlackBerry] Implement a popup client for HTML controls
https://bugs.webkit.org/show_bug.cgi?id=85670

Attachment 140758: updated patch
https://bugs.webkit.org/attachment.cgi?id=140758&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140758&action=review


Looks good, can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:212
> +    JSC::UString name("popUp");

Yong can review this better than me. I do wonder if popUp is a good name.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:233
> +		   event);

Combine the two lines above into one line.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp:258
> +}

I think early return is preferred here:

if (!m_page) {
    m_page->clear();
    return;
}
m_page->
....