[webkit-reviews] review requested: [Bug 85690] [chromium] Should not use a timer to tick backgrounded animations in single thread mode : [Attachment 140746] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 85690: [chromium] Should not use a timer to tick backgrounded animations in
single thread mode
https://bugs.webkit.org/show_bug.cgi?id=85690

Attachment 140746: Patch
https://bugs.webkit.org/attachment.cgi?id=140746&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #3)
> Since we never composite while not visible, what ensures that "hardware"
animations still advance and fire WebCore notifications in background tabs?  Or
do we not need to do that?

With https://bugs.webkit.org/show_bug.cgi?id=84620, when the
CCSingleThreadProxy is asked to commit, it will notice
when the composite it schedules won't actually result in a composite (because
we're hidden), and manually schedule one if there's an animation.
This will not result in any drawing while hidden, though -- the code will bail
early if we're not visible. This will advance the hardware
animations.