[webkit-reviews] review granted: [Bug 85084] [chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium. : [Attachment 140716] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 85084: [chromium] Create LinkHighlightLayerChromium class to provide
link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084

Attachment 140716: Patch
https://bugs.webkit.org/attachment.cgi?id=140716&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140716&action=review


> Source/WebCore/platform/graphics/chromium/LinkHighlight.h:43
> +    virtual	~LinkHighlight();

extra space between "virtual" and "~LinkHighlight"

> Source/WebKit/chromium/tests/LinkHighlightTest.cpp:44
> +

extra newline

> Source/WebKit/chromium/tests/LinkHighlightTest.cpp:49
> +    virtual void notifyAnimationStarted(const GraphicsLayer*, double time) {
}
> +    virtual void notifySyncRequired(const GraphicsLayer*) { }
> +    virtual void paintContents(const GraphicsLayer*, GraphicsContext&,
GraphicsLayerPaintingPhase, const IntRect& inClip) { }
> +    virtual bool showDebugBorders(const GraphicsLayer*) const { return
false; }
> +    virtual bool showRepaintCounter(const GraphicsLayer*) const { return
false; }

OVERRIDE please?