[webkit-reviews] review granted: [Bug 34875] offsetLeft broken within CSS3 columns : [Attachment 140565] Patch (with changes from comment 11)

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 34875: offsetLeft broken within CSS3 columns
https://bugs.webkit.org/show_bug.cgi?id=34875

Attachment 140565: Patch (with changes from comment 11)
https://bugs.webkit.org/attachment.cgi?id=140565&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140565&action=review


Looks good, I have one last comment but the change is neat.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:558
> +	       while (curr && curr != offsetParent) {

I think the |curr| NULL-check is unneeded here. You know |curr| and
curr->parent() cannot be NULL as |curr| is a descendant of |offsetParent|
(which is non-NULL).