[webkit-reviews] review granted: [Bug 85496] [Qt] Add QML/WK2 evaluateJavaScript experimental API : [Attachment 140701] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 8 06:48:38 PDT 2012


Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 85496: [Qt] Add QML/WK2 evaluateJavaScript experimental API
https://bugs.webkit.org/show_bug.cgi?id=85496

Attachment 140701: Patch
https://bugs.webkit.org/attachment.cgi?id=140701&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140701&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1291
> +    closure->method = 0;

This line isn't necessary given that method is a QByteArray that has a
constructor.


More information about the webkit-reviews mailing list