[webkit-reviews] review granted: [Bug 85839] [Qt] Unbreak debugging of WebKit2. : [Attachment 140619] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 8 06:30:17 PDT 2012
Simon Hausmann <hausmann at webkit.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 85839: [Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839
Attachment 140619: Patch
https://bugs.webkit.org/attachment.cgi?id=140619&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140619&action=review
> Source/WebKit2/qt/MainQt.cpp:68
> + sigaction(SIGCONT, 0, &oldAction);
> + sigaction(SIGCONT, &newAction, 0);
I think you should combine these into one call, i.e.
sigaction(SIGCONT, &newAction, &oldAction);
More information about the webkit-reviews
mailing list