[webkit-reviews] review canceled: [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges() : [Attachment 140487] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 84435: [EFL][DRT] EFL's DRT needs to support
LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435

Attachment 140487: Patch
https://bugs.webkit.org/attachment.cgi?id=140487&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Ok, back to the beginning :) As it turns out, the icon type is only relevant on
apple (only apple has touch-icons, other ports only have favicons: Bug 59143).
Therefore, I removed the iconType parameter from the "icon,changed" signal and
added an assert to make sure the iconType is always WebCore::Favicon.