[webkit-reviews] review denied: [Bug 85576] [BlackBerry] AutofillManager implementation upstream : [Attachment 140642] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 85576: [BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576

Attachment 140642: Patch
https://bugs.webkit.org/attachment.cgi?id=140642&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140642&action=review


Sorry, needs one more iteration :)

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:31
> +static bool isNotAutofillable(HTMLInputElement* element)

I think this is better to reverse this logic, ie. make it isAutofillable, and
test for ! isNotAutofillable().