[webkit-reviews] review granted: [Bug 85573] Add a layout test for covering MEDIA_ERR_NETWORK errors : [Attachment 140641] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 85573: Add a layout test for covering MEDIA_ERR_NETWORK errors
https://bugs.webkit.org/show_bug.cgi?id=85573

Attachment 140641: Patch
https://bugs.webkit.org/attachment.cgi?id=140641&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140641&action=review


You should add this to the skipped list of platforms where you know it will
fail.

Thanks!

> LayoutTests/ChangeLog:3
> +	   Add a layout test for to verify MEDIA_ERR_NETWORK is raised when the
HTTP connection suddently terminates.

typo: "for to verify"

> LayoutTests/http/tests/media/resources/serve-video.php:14
> +	   if (is_numeric($range[1]))

Good one, thanks!

> LayoutTests/http/tests/media/resources/serve-video.php:40
> +    if ($truncate) {
> +	   $end -= 50 * 1024;
> +    }

Nit: these braces aren't necessary.

> LayoutTests/http/tests/media/video-network-error.html:19
> +	       function canplay() {
> +		   video.play();
> +	       }

Or here.