[webkit-reviews] review denied: [Bug 85576] [BlackBerry] AutofillManager implementation upstream : [Attachment 140625] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 85576: [BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576

Attachment 140625: Patch
https://bugs.webkit.org/attachment.cgi?id=140625&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140625&action=review


Looks good, can be improved some more.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:45
> +    Vector<String> candidates =
autofillBackingStore().get(element->getAttribute("name").string(),
element->value());

Can you use HTMLNames::nameAttr here? Also is this line needed since you are
not using candidates.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:66
> +	       || element->isAutofilled() || !element->shouldAutocomplete())

You are doing these checks here and in didChangeInTextField, can you make a
static function for this in this .cpp?

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp:68
> +	   autofillBackingStore().add(element->getAttribute("name").string(),
element->value());

Can you use HTMLNames::nameAttr here?