[webkit-reviews] review granted: [Bug 85842] [Chromium] Android wishes to use an empty implementation if AXObjectCache : [Attachment 140618] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 85842: [Chromium] Android wishes to use an empty implementation if
AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=85842

Attachment 140618: Patch
https://bugs.webkit.org/attachment.cgi?id=140618&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140618&action=review


> Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:76
> +bool nodeHasRole(Node*, const String& role)
> +{
> +    UNUSED_PARAM(role);

Nit: Can you just remove |role| on line 74 and not have to call UNUSED_PARAM?

> Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:150
> +void AXObjectCache::postNotification(RenderObject*, AXNotification, bool
postToElement, PostType)
> +{
> +    UNUSED_PARAM(postToElement);
> +}

Ditto.

> Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:155
> +void AXObjectCache::postNotification(AccessibilityObject*, Document*,
AXNotification, bool postToElement, PostType)
> +{
> +    UNUSED_PARAM(postToElement);
> +}

Ditto.

> Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:168
> +void AXObjectCache::nodeTextChangeNotification(RenderObject*, AXTextChange,
unsigned offset, const String&)
> +{
> +    UNUSED_PARAM(offset);
> +}

Ditto.

> Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:200
> +void AXObjectCache::handleFocusedUIElementChanged(RenderObject*,
RenderObject* newFocusedRenderer)
> +{
> +    UNUSED_PARAM(newFocusedRenderer);
> +}

Ditto.