[webkit-reviews] review granted: [Bug 85840] REGRESSION (r101575): Chinese input is broken when composing mail in iCloud using Safari : [Attachment 140615] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 85840: REGRESSION (r101575): Chinese input is broken when composing mail in
iCloud using Safari
https://bugs.webkit.org/show_bug.cgi?id=85840

Attachment 140615: Patch
https://bugs.webkit.org/attachment.cgi?id=140615&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140615&action=review


Enrica and myself looked into making a regression test, and determined it
impractical. We don't want adding new tests for DOM modification events, and
simulating what the page does without mutation events cannot be tested because
we don't have appropriate input context hooks.

> Source/WebCore/editing/InsertTextCommand.cpp:119
> +	   deleteSelection(false, true, true, false, false);

We should make this readable by using enums or a parameter struct.