[webkit-reviews] review granted: [Bug 85836] [chromium] move event_listener_unittest to webkit_unit_tests : [Attachment 140609] Patch

Mon May 7 15:48:48 PDT 2012

James Robinson <jamesr at chromium.org> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 85836: [chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836

Attachment 140609: Patch
https://bugs.webkit.org/attachment.cgi?id=140609&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140609&action=review

Death to test_shell_tests (and test_shell)!

> Source/WebKit/chromium/tests/EventListenerTest.cpp:78
> +	   std::string baseURL("http://www.test.com/");

nit: shouldn't we use example.com ? test.com is a real domain, example.com is
an RFC 2606 (?) placeholder

> Source/WebKit/chromium/tests/data/listener/mutation_event_listener.html:1
> +<html>

<!DOCTYPE html> unless we need quirks mode for this test